Issue 155051: Foundations for Print Preview and Setup HTML Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155051: Foundations for Print Preview and Setup HTML Views (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
M-A Ruel, Sverrir

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initial html page views for print preview and setup This is still the foundation, has no implementation, just plain old html and its structure. BUG=173, 947 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19918

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/print_tab.css	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/print_tab.html	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/print_tab.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

Note: its just the structure, no implementation yet. Let me know if the naming conventions ...

11 years, 5 months ago (2009-07-03 12:23:06 UTC) #1

M-A Ruel

lgtm with nits It will probably require a clobber, yay... http://codereview.chromium.org/155051/diff/1/4 File chrome/browser/resources/print_tab.css (right): http://codereview.chromium.org/155051/diff/1/4#newcode1 ...

11 years, 5 months ago (2009-07-03 12:34:00 UTC) #2

LGTM

Expand Messages | Collapse Messages