Issue 155040: GTK: Give the aboot dialog a facelift....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155040: GTK: Give the aboot dialog a facelift.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy, Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

GTK: Give the aboot dialog a facelift. BUG=http://crbug.com/15897 TEST=get Glen to look at it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19966

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -60 lines)			Patch
M	chrome/browser/gtk/about_chrome_dialog.cc	View	5 chunks	+106 lines, -53 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.cc	View	3 chunks	+25 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Stade

see www/~estade/no_crawl/aboutchromium.png There is some weird spacing due to the link buttons; I don't off ...

11 years, 5 months ago (2009-07-03 03:31:51 UTC) #1

Glen Murphy

Dialog screenshot LGTM, ignoring the link padding issue.

11 years, 5 months ago (2009-07-06 18:21:29 UTC) #2

Code LGTM.