Issue 155026: Fix the current remaining Views-GTK compile and linker errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155026: Fix the current remaining Views-GTK compile and linker errors. (Closed)

Created:
11 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix the current remaining Views-GTK compile and linker errors. Chrome still doesn't run. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19977

Patch Set 1 #

Patch Set 2 : Some forgotten changes. #

Total comments: 1

Patch Set 3 : New patch #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -7 lines)			Patch
M	chrome/browser/browser_theme_provider.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/views/dialog_stubs_gtk.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/views/status_bubble_views.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+24 lines, -3 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View	1 2	2 chunks	+25 lines, -0 lines	0 comments	Download
M	views/controls/single_split_view.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 5 months ago (2009-07-02 23:31:28 UTC) #2

LGTM

http://codereview.chromium.org/155026/diff/14/1003
File chrome/browser/gtk/bookmark_manager_gtk.cc (right):

http://codereview.chromium.org/155026/diff/14/1003#newcode523
Line 523: // GTK+Views should implement this somehow.
If I were you I'd just not build this file.

Expand Messages | Collapse Messages