Issue 155020: Speed up net_unittests by ~20s by manipulating tcp_pinger timeouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155020: Speed up net_unittests by ~20s by manipulating tcp_pinger timeouts. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Speed up net_unittests by ~20s by manipulating tcp_pinger timeouts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19951

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/socket/tcp_pinger.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

What do you think? net_unittests launch testserver a lot of times, and waiting for startup ...

11 years, 5 months ago (2009-07-02 22:18:33 UTC) #1

tony

11 years, 5 months ago (2009-07-03 00:54:59 UTC) #2

I think this is a good change to make.  LGTM.

I tried at one point to have the test server start once per test .cc file
(static SetUp method), but it resulted in a bunch of other failures (maybe the
test server can't handle all the requests?).  It would be nice if we didn't have
to restart the server between every test.

Expand Messages | Collapse Messages