Issue 155018: Add more code to debug a crash inside HttpCache::DeactivateEntry...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155018: Add more code to debug a crash inside HttpCache::DeactivateEntry... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add more code to debug a crash inside HttpCache::DeactivateEntry BUG=9952 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19981

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
	M	net/http/http_cache.h	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	net/http/http_cache.cc	View		9 chunks	+33 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 5 months ago (2009-07-06 18:27:05 UTC) #2

LGTM, good luck!

http://codereview.chromium.org/155018/diff/1/3
File net/http/http_cache.h (right):

http://codereview.chromium.org/155018/diff/1/3#newcode186
Line 186: bool deleted_;  // TODO(rvargas): remove this member.
maybe include a bug link?  then if the bug is closed, we can know to delete this
code.

Expand Messages | Collapse Messages