Issue 155011: Add checks to track down crashes in URLRequestChromeJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155011: Add checks to track down crashes in URLRequestChromeJob. (Closed)

Created:
11 years, 5 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add checks to track down crashes in URLRequestChromeJob. BUG=http://crbug.com/13924 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19950

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	chrome/browser/dom_ui/chrome_url_data_manager.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/dom_ui/chrome_url_data_manager.cc	View		4 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

I only see two possibilities. Either we're accessing a deleted URLRequestChromeJob, and the IOBuffer subtype ...

11 years, 5 months ago (2009-07-02 21:03:17 UTC) #1

rvargas (doing something else)

11 years, 5 months ago (2009-07-02 21:22:04 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/155011/diff/1/3
File chrome/browser/dom_ui/chrome_url_data_manager.h (right):

http://codereview.chromium.org/155011/diff/1/3#newcode115
Line 115: bool HasPendingJob(URLRequestChromeJob* job) const;
Could you add a comment for this method?

Expand Messages | Collapse Messages