Issue 155010: Port WebImage to CG and rework the Skia version so that WebImage just has a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155010: Port WebImage to CG and rework the Skia version so that WebImage just has a... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Port WebImage to CG and rework the Skia version so that WebImage just has a SkBitmap member (avoiding a level of indirection). This CL makes it so that Mac Chrome will now write bitmap data to the clipboard when requested by WebKit. I also simplified the ImageDecoder class that lives in glue. BUG=15648 TEST=none R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19898

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -154 lines)			Patch
M	webkit/api/public/WebImage.h	View		4 chunks	+34 lines, -53 lines	0 comments	Download
A	webkit/api/src/WebImageCG.cpp	View	1	1 chunk	+92 lines, -0 lines	0 comments	Download
M	webkit/api/src/WebImageSkia.cpp	View	1	3 chunks	+29 lines, -43 lines	0 comments	Download
M	webkit/glue/image_decoder.cc	View		2 chunks	+13 lines, -52 lines	0 comments	Download
M	webkit/glue/webclipboard_impl.cc	View		2 chunks	+14 lines, -3 lines	0 comments	Download
M	webkit/webkit.gyp	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages