Issue 1550003: Stop watching the netlink file descriptor before the message pump is destroye...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1550003: Stop watching the netlink file descriptor before the message pump is destroye... (Closed)

Created:
10 years, 8 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Stop watching the netlink file descriptor before the message pump is destroyed. A better fix is to make FileDescriptorWatcher handle this internally, will track that as a follow-up issue. BUG=39932 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44296

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : Add HANDLE_EINTR wrapper #

Patch Set 5 : syn and resolve #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -8 lines)			Patch
	M	net/base/network_change_notifier_linux.h	View	1 2 3 4	3 chunks	+11 lines, -2 lines	0 comments	Download
	M	net/base/network_change_notifier_linux.cc	View	1 2 3 4	4 chunks	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

Apparently I never published this. We discussed via email how this fits into the bigger ...

10 years, 8 months ago (2010-04-12 19:03:58 UTC) #1

willchan no longer on Chromium

lgtm http://codereview.chromium.org/1550003/diff/8001/9002 File net/base/network_change_notifier_linux.cc (right): http://codereview.chromium.org/1550003/diff/8001/9002#newcode97 net/base/network_change_notifier_linux.cc:97: if (close(netlink_fd_) != 0) I know you're just ...

10 years, 8 months ago (2010-04-12 22:04:24 UTC) #2

eroman

10 years, 8 months ago (2010-04-12 22:17:00 UTC) #3

On 2010/04/12 22:04:24, willchan wrote:
> lgtm
> 
> http://codereview.chromium.org/1550003/diff/8001/9002
> File net/base/network_change_notifier_linux.cc (right):
> 
> http://codereview.chromium.org/1550003/diff/8001/9002#newcode97
> net/base/network_change_notifier_linux.cc:97: if (close(netlink_fd_) != 0)
> I know you're just moving my bad code, but I see that I forgot to wrap this
call
> in HANDLE_EINTR.  Please add that in here.

Done.

Expand Messages | Collapse Messages