Issue 1549031: Call to C function support in macro assembler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1549031: Call to C function support in macro assembler... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Call to C function support in macro assembler Implement macro assembler operations PrepareCallCFunction and CallCFunction like on both Intel platforms. Used these for direct calls to C functions. Committed: http://code.google.com/p/v8/source/detail?r=4374

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -75 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 2	2 chunks	+13 lines, -17 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View		6 chunks	+7 lines, -42 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM. Lets keep an eye on performance because the 'pushing sp onto the stack' stuff ...

10 years, 8 months ago (2010-04-09 10:47:22 UTC) #2

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-09 11:21:32 UTC) #3

http://codereview.chromium.org/1549031/diff/7001/8002
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1549031/diff/7001/8002#newcode5970
src/arm/codegen-arm.cc:5970: // substract the tag from r4.
On 2010/04/09 10:47:22, Erik Corry wrote:
> From r5.

Done.

Expand Messages | Collapse Messages