Issue 1549021: GTK: Don't show toolbar border without the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1549021: GTK: Don't show toolbar border without the toolbar. (Closed)

Created:
10 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Don't show toolbar border without the toolbar. BUG=39172 TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43685

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View		4 chunks	+9 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/1549021/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/1549021/diff/1/2#newcode1582 chrome/browser/gtk/browser_window_gtk.cc:1582: intentional?

10 years, 8 months ago (2010-04-06 01:35:38 UTC) #2

Evan Stade

10 years, 8 months ago (2010-04-06 01:39:39 UTC) #3

http://codereview.chromium.org/1549021/diff/1/2
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/1549021/diff/1/2#newcode1582
chrome/browser/gtk/browser_window_gtk.cc:1582: 
On 2010/04/06 01:35:39, Evan Martin wrote:
> intentional?

no

Expand Messages | Collapse Messages