Issue 1549001: Merge 56663 - CSSPrimitiveValue::setFloatValue/setStringValue should throw an...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1549001: Merge 56663 - CSSPrimitiveValue::setFloatValue/setStringValue should throw an... (Closed)

Created:
10 years, 9 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/WebKit/249/

Visibility:
Public.

Description

Merge 56663 - CSSPrimitiveValue::setFloatValue/setStringValue should throw an exception if passed an incorrect unit type. <http://webkit.org/b/36680>; / <rdar://problem/7801016> Reviewed by Darin Adler. WebCore: Test: fast/dom/setPrimitiveValueexceptions.html * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): Throw an INVALID_ACCESS_ERR if either of our type or the passedin type is not a numeric type. (WebCore::CSSPrimitiveValue::setStringValue): Throw an INVALID_ACCESS_ERR if either of our type or the passedin type is not a string type. LayoutTests: * fast/dom/scripttests/setPrimitiveValueexceptions.js: Added. * fast/dom/setPrimitiveValueexceptionsexpected.txt: Added. * fast/dom/setPrimitiveValueexceptions.html: Copied from LayoutTests/fast/dom/eventattributeavailability.html. TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42929

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -8 lines)			Patch
A	LayoutTests/fast/dom/script-tests/setPrimitiveValue-exceptions.js	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/setPrimitiveValue-exceptions.html	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/setPrimitiveValue-exceptions-expected.txt	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	WebCore/css/CSSPrimitiveValue.cpp	View	2 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages