Issue 1547038: cgptlib stub for verified boot development.

Issue 1547038: cgptlib stub for verified boot development. (Closed)

Created:
10 years, 8 months ago by Louis

Modified:
9 years, 4 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

cgptlib stub for verified boot development.

Patch Set 1 #

Total comments: 16

Patch Set 2 : coding-style fix #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -0 lines)			Patch
	A	src/platform/vboot_reference/cgptlib/cgpt.h	View	1	1 chunk	+88 lines, -0 lines	0 comments	Download
	A	src/platform/vboot_reference/cgptlib/cgpt.c	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gauravsh

LGTM after you fix the 80 char and comment-style problems below http://codereview.chromium.org/1547038/diff/1/2 File src/platform/vboot_reference/cgptlib/cgpt.c (right): ...

10 years, 8 months ago (2010-04-20 02:57:03 UTC) #2

Louis

Thanks for review. I thought it is just a quick hack, but glad to fix ...

10 years, 8 months ago (2010-04-20 03:13:20 UTC) #3

Thanks for review. I thought it is just a quick hack, but glad to fix
coding-style issue.

http://codereview.chromium.org/1547038/diff/1/2
File src/platform/vboot_reference/cgptlib/cgpt.c (right):

http://codereview.chromium.org/1547038/diff/1/2#newcode24
src/platform/vboot_reference/cgptlib/cgpt.c:24: gpt->modified |= 5 <<
gpt->current_kernel;
sorry. I've fixed with its actual value (GPT_MODIFIED_HEADER1 |
GPT_MODIFIED_ENTRIES1).

On 2010/04/20 02:57:03, gauravsh wrote:
> can you add a comment explaining what the above line does? Where does the
magic
> number 5 come from?

http://codereview.chromium.org/1547038/diff/1/3
File src/platform/vboot_reference/cgptlib/cgpt.h (right):

http://codereview.chromium.org/1547038/diff/1/3#newcode32
src/platform/vboot_reference/cgptlib/cgpt.h:32: uint8_t *header1;       // GPT
primary header, from sector 1 of disk
On 2010/04/20 02:57:03, gauravsh wrote:
> Certain C compilers will barf at C++ style comments since this is not ANSI C
> compliant. Can you change this to use /* */ style comments?

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode34
src/platform/vboot_reference/cgptlib/cgpt.h:34: uint8_t *header2;       // GPT
secondary header, from last sector of disk
On 2010/04/20 02:57:03, gauravsh wrote:
> 80 chars

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode35
src/platform/vboot_reference/cgptlib/cgpt.h:35: //   (sizE: 512 bytes)
On 2010/04/20 02:57:03, gauravsh wrote:
> size

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode38
src/platform/vboot_reference/cgptlib/cgpt.h:38: uint8_t *entries2;      //
secondary GPT table, precedes secondary header
On 2010/04/20 02:57:03, gauravsh wrote:
> 80 chars

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode63
src/platform/vboot_reference/cgptlib/cgpt.h:63: *   GPT_ERROR_INVALID_HEADERS,
both partition table headers are invalid, enters recovery mode,
On 2010/04/20 02:57:03, gauravsh wrote:
> 80 chars

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode64
src/platform/vboot_reference/cgptlib/cgpt.h:64: *   GPT_ERROR_INVALID_ENTRIES,
both partition table entries are invalid, enters recovery mode,
On 2010/04/20 02:57:03, gauravsh wrote:
> 80 chars

Done.

http://codereview.chromium.org/1547038/diff/1/3#newcode66
src/platform/vboot_reference/cgptlib/cgpt.h:66: *  
GPT_ERROR_INVALID_SECTOR_NUMBER, number of sectors in drive is invalid (too
small) */
On 2010/04/20 02:57:03, gauravsh wrote:
> 80 chars

Done.

gauravsh

10 years, 8 months ago (2010-04-20 03:37:45 UTC) #5

LGTM

On Mon, Apr 19, 2010 at 8:13 PM, <yjlou@chromium.org> wrote:

> http://codereview.chromium.org/1547038/show
>



-- 
-g

Expand Messages | Collapse Messages