Extend From() to allow importing from different mappings. Also...

Extend From() to allow importing from different mappings.  Also
allow From() to import when the URL is relative.

For example, if src/DEPS is:
deps = {
  'base' = 'svn://svn/base@123',
  'main' = From('base', 'src/main'),
}
and base/DEPS is:
deps = {
  'src/main': '/main@100',
}

This will checkout svn://svn/main@100 in main.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44044

[tony, 2010-04-08 07:50:38]

This is the second set of changes to gclient for
https://bugs.webkit.org/show_bug.cgi?id=36578

[M-A Ruel, 2010-04-08 13:55:50]

lgtm with a few small changes.

http://codereview.chromium.org/1547026/diff/1/3
File gclient.py (right):

http://codereview.chromium.org/1547026/diff/1/3#newcode448
gclient.py:448: if type(sub_deps_base_url) != str:
if isinstance(sub_deps_base_url, basestring):

http://codereview.chromium.org/1547026/diff/1/3#newcode801
gclient.py:801: sub_deps = self._ParseSolutionDeps(deps[d].module_name, content,
{}, False)
80 cols

http://codereview.chromium.org/1547026/diff/1/3#newcode802
gclient.py:802: sub_deps_base_url = deps[deps[d].module_name]
That changes the logic a bit, I'd like a comment about why look at the global
level.

[tony, 2010-04-09 02:17:45]

Thanks!

http://codereview.chromium.org/1547026/diff/1/3
File gclient.py (right):

http://codereview.chromium.org/1547026/diff/1/3#newcode448
gclient.py:448: if type(sub_deps_base_url) != str:
On 2010/04/08 13:55:51, Marc-Antoine Ruel wrote:
> if isinstance(sub_deps_base_url, basestring):

Done.

http://codereview.chromium.org/1547026/diff/1/3#newcode801
gclient.py:801: sub_deps = self._ParseSolutionDeps(deps[d].module_name, content,
{}, False)
On 2010/04/08 13:55:51, Marc-Antoine Ruel wrote:
> 80 cols

Done.

http://codereview.chromium.org/1547026/diff/1/3#newcode802
gclient.py:802: sub_deps_base_url = deps[deps[d].module_name]
On 2010/04/08 13:55:51, Marc-Antoine Ruel wrote:
> That changes the logic a bit, I'd like a comment about why look at the global
> level.

Done.