Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1547007: Don't run UnloadTest.CrossSiteInfiniteUnloadSync under TSan... (Closed)

Created:
10 years, 8 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, stuartmorgan, Timur Iskhodzhanov, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't run UnloadTest.CrossSiteInfiniteUnloadSync under TSan Here's an example output of the failure: [----------] 1 test from UnloadTest [ RUN ] UnloadTest.CrossSiteInfiniteUnloadSync [5442:5442:0330/051539:6569997191168:INFO:chrome/test/ui/ui_test.cc(1199)] BROWSER_WRAPPER was set, prefixing command_line with /b/slave/chromium-rel-linux-tsan-ui/build/valgrind.tmp/browser_wrapper.KXl4L_ Extracting ThreadSanitizer to /tmp/valgrind.de5700 chrome/test/ui/ui_test.cc:595: Failure Value of: tab_proxy->NavigateToURLBlockUntilNavigationsComplete( url, number_of_navigations) Actual: 0 Expected: AUTOMATION_MSG_NAVIGATION_SUCCESS Which is: 1 http://mock.http/title2.html chrome/browser/unload_uitest.cc:127: Failure Value of: GetActiveTabTitle() Actual: L"" Expected: expected_title Which is: L"Title Of Awesomeness" [ FAILED ] UnloadTest.CrossSiteInfiniteUnloadSync (556591 ms) [----------] 1 test from UnloadTest (556591 ms total) BUG=32529 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/data/valgrind/ui_tests.gtest-tsan.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
10 years, 8 months ago (2010-03-30 12:45:47 UTC) #1
Alexander Potapenko
10 years, 8 months ago (2010-04-02 09:57:45 UTC) #2
On 2010/03/30 12:45:47, Timur Iskhodzhanov wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698