Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1547003: [GTTF] Miscellanous UI tests cleanups: (Closed)

Created:
10 years, 9 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

[GTTF] Miscellanous UI tests cleanups: - use built-in timeouts instead of "inventing" them in each test case - avoid unneeded checks and operations - use automation calls more effectively - use FLAKY mark instead of DISABLED to maintain test coverage - split some tests to make the above possible TEST=UI test based BUG=39785 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43070

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -146 lines) Patch
M chrome/browser/metrics/metrics_service_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 3 chunks +4 lines, -19 lines 0 comments Download
M chrome/browser/process_singleton_linux_uitest.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/process_singleton_win_uitest.cc View 1 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/repost_form_warning_uitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/session_history_uitest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/sessions/session_restore_uitest.cc View 10 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/unload_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 8 chunks +21 lines, -40 lines 0 comments Download
M chrome/test/ui/fast_shutdown_uitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/ui/history_uitest.cc View 1 4 chunks +22 lines, -16 lines 0 comments Download
M chrome/test/ui/mouseleave_uitest.cc View 1 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/test/ui/omnibox_uitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/ui/v8_benchmark_uitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 1 6 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 9 months ago (2010-03-29 12:50:37 UTC) #1
brettw
LGTM http://codereview.chromium.org/1547003/diff/1/5 File chrome/browser/process_singleton_win_uitest.cc (right): http://codereview.chromium.org/1547003/diff/1/5#newcode94 chrome/browser/process_singleton_win_uitest.cc:94: int timeout_ms_; Technically member data should go below ...
10 years, 9 months ago (2010-03-29 16:59:54 UTC) #2
Nicolas Sylvain
10 years, 8 months ago (2010-03-29 22:54:29 UTC) #3
lgtm

http://codereview.chromium.org/1547003/diff/1/13
File chrome/test/ui/history_uitest.cc (right):

http://codereview.chromium.org/1547003/diff/1/13#newcode47
chrome/test/ui/history_uitest.cc:47: TEST_F(HistoryTester,
DISABLED_VerifyHistoryLength2) {
is there a bug number? Can we write it there?

Powered by Google App Engine
This is Rietveld 408576698