Retry N-1 times with the --jobs flag, then drop it

Retry N-1 times with the --jobs flag, then drop it

[Brian Daugherty, 2010-04-20 19:09:28]

On 2010/04/16 22:59:34, Nasser Grainawi wrote:
> 

lgtm. Verify with the sherrifs, djmm & adlr to see if the flag is currently in
use in Buildbot and give them a heads up. It seems to be a side-effect free
change though.

[robotboy, 2010-04-20 20:28:24]

Hmm, I know that there was a reason it was done this way, but I don't know
exactly what it was.  I've added some people that might as reviewers.

[djmm, 2010-04-20 21:20:21]

Adding sosa who added eretry().

[sosa, 2010-04-20 21:27:35]

Adding davidjames who added eretry :D

On Tue, Apr 20, 2010 at 2:20 PM,  <djmm@chromium.org> wrote:
> Adding sosa who added eretry().
>
> http://codereview.chromium.org/1545043/show
>

[David James, 2010-04-21 00:57:30]

On Tue, Apr 20, 2010 at 12:09 PM,  <bdaugher@codeaurora.org> wrote:
> On 2010/04/16 22:59:34, Nasser Grainawi wrote:
> lgtm. Verify with the sherrifs, djmm & adlr to see if the flag is currently
> in
> use in Buildbot and give them a heads up. It seems to be a side-effect free
> change though.

This change is fine with me. When --jobs and --retries are used
together, the main reason why the build would fail intermittently is
due to concurrency issues.  Occasionally, we also run into
intermittent build issues without --jobs (e.g. due to connection
problems), but that happens less often. Nasser's patch might allow for
faster builds in a situation where the speed advantage of --jobs makes
up for the fact that you have to retry multiple times.

The buildbot does use --retries, but it doesn't use --jobs, so the
patch won't affect the buildbot.

Cheers,

David

[robotboy, 2010-04-21 00:58:40]

LGTM then.  Thanks.

[Brian Daugherty, 2010-04-21 14:48:31]

Nasser, this has been committed. Please watch the waterfalls and close the
issue.