Issue 1545034: Do not call NSS functions if NSS initialization failed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1545034: Do not call NSS functions if NSS initialization failed.... (Closed)

Created:
10 years, 8 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Do not call NSS functions if NSS initialization failed. R=agl BUG=36071 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44728

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -3 lines)			Patch
M	base/nss_util.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/x509_certificate_nss.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM. I would also be fine with just bailing out if NSS init fails.

10 years, 8 months ago (2010-04-14 14:10:10 UTC) #2

wtc

10 years, 8 months ago (2010-04-14 16:51:28 UTC) #3

On 2010/04/14 14:10:10, agl wrote:
> 
> I would also be fine with just bailing out if NSS init fails.

I agree.  It's impractical to check before all NSS calls.  I
only protect the SSL and certificate code in this CL, but the
crypto code in base also calls NSS.

It's just that I don't know how to display UI to tell the user why
we're bailing out.

Expand Messages | Collapse Messages