Issue 1543003: - Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1543003: - Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac... (Closed)

Created:
10 years, 9 months ago by Peter Valchev

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Evan Martin, Mads Ager (chromium)

CC:
v8-dev, evanm_chromium.org

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac - FreeBSD GYP changes based on work by sprewell@jaggeri.com

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
M	src/globals.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1	3 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

This seems good to me, but I don't know a lot about v8. CC'ing ager ...

10 years, 8 months ago (2010-03-30 13:51:42 UTC) #2

Erik Corry

LGTM http://codereview.chromium.org/1543003/diff/5001/6003 File src/globals.h (right): http://codereview.chromium.org/1543003/diff/5001/6003#newcode117 src/globals.h:117: #define USING_OTHER_ABI I dislike this name. Given that ...

10 years, 8 months ago (2010-03-31 21:30:20 UTC) #3

Peter Valchev

Thanks Erik. It turns out the instructions I followed to send a v8 patch created ...

10 years, 8 months ago (2010-04-01 15:50:43 UTC) #4

Committed to bleeding edge.

Expand Messages | Collapse Messages

Issue 1543003: - Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages