Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 1540009: [Mac] Move star button into page-actions area of omnibox. (Closed)
Patch Set: Why did the trybot fail? I can't see anything. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm
index 62aba3dd33269b7dfc2c274f1c759ecd91d6e6c2..91b891d96dd58eb44757ca6d53660404757723d3 100644
--- a/chrome/browser/cocoa/browser_window_controller.mm
+++ b/chrome/browser/cocoa/browser_window_controller.mm
@@ -1368,13 +1368,13 @@
return phase;
}
-- (NSPoint)topLeftForBubble {
- NSRect rect = [toolbarController_ starButtonInWindowCoordinates];
- NSPoint p = NSMakePoint(NSMinX(rect), NSMinY(rect)); // bottom left
+- (NSPoint)topRightForBubble {
+ NSRect rect = [toolbarController_ starIconInWindowCoordinates];
+ NSPoint p = NSMakePoint(NSMaxX(rect), NSMinY(rect)); // bottom right
- // Adjust top-left based on our knowledge of how the view looks.
- p.x -= 2;
- p.y += 7;
+ // Adjust top-right based on our knowledge of how the view looks.
+ p.x += 31;
+ p.y += 5;
return p;
}
@@ -1385,10 +1385,10 @@
if (!bookmarkBubbleController_) {
BookmarkModel* model = browser_->profile()->GetBookmarkModel();
const BookmarkNode* node = model->GetMostRecentlyAddedNodeForURL(url);
- NSPoint topLeft = [self topLeftForBubble];
+ NSPoint topRight = [self topRightForBubble];
bookmarkBubbleController_ =
[[BookmarkBubbleController alloc] initWithParentWindow:[self window]
- topLeftForBubble:topLeft
+ topRightForBubble:topRight
model:model
node:node
alreadyBookmarked:alreadyMarked];
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.h ('k') | chrome/browser/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698