Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Issue 1540009: [Mac] Move star button into page-actions area of omnibox. (Closed)
Patch Set: Why did the trybot fail? I can't see anything. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
diff --git a/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm b/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
index 530d20346e7cf1bf5cbd57928dc9e9c48c8eb449..abc991cc431163808bdc30f7212b69d3b261da04 100644
--- a/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
+++ b/chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
@@ -42,7 +42,7 @@ class BookmarkBubbleControllerTest : public CocoaTest {
}
controller_ = [[BookmarkBubbleController alloc]
initWithParentWindow:test_window()
- topLeftForBubble:TopLeftForBubble()
+ topRightForBubble:TopRightForBubble()
model:helper_.profile()->GetBookmarkModel()
node:node
alreadyBookmarked:YES];
@@ -61,8 +61,8 @@ class BookmarkBubbleControllerTest : public CocoaTest {
return [static_cast<InfoBubbleWindow*>([controller_ window]) isClosing];
}
- NSPoint TopLeftForBubble() {
- return NSMakePoint(10, 300);
+ NSPoint TopRightForBubble() {
+ return NSMakePoint(NSWidth([test_window() frame]) - 10, 300);
}
};
@@ -334,7 +334,7 @@ TEST_F(BookmarkBubbleControllerTest, EscapeRemovesNewBookmark) {
BookmarkBubbleController* controller =
[[BookmarkBubbleController alloc]
initWithParentWindow:test_window()
- topLeftForBubble:TopLeftForBubble()
+ topRightForBubble:TopRightForBubble()
model:helper_.profile()->GetBookmarkModel()
node:node
alreadyBookmarked:NO]; // The last param is the key difference.
« no previous file with comments | « chrome/browser/cocoa/bookmark_bubble_controller.mm ('k') | chrome/browser/cocoa/browser_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698