Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1539038: Report approximated duration in milliseconds for profile nodes. (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Report approximated duration in milliseconds for profile nodes. The simple formula "ms = ticks * sampler_interval" doesn't work, because e.g. on Linux, the actual sampling rate can be 5 times lower than the one set up in the code. To calculate actual sampling rate, current time is periodically queried and processed along with actual sampling ticks count. Committed: http://code.google.com/p/v8/source/detail?r=4427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -24 lines) Patch
M src/api.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/profile-generator.h View 10 chunks +60 lines, -5 lines 0 comments Download
M src/profile-generator.cc View 11 chunks +59 lines, -10 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 3 chunks +53 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
10 years, 8 months ago (2010-04-15 09:41:37 UTC) #1
Søren Thygesen Gjesse
LGTM Is the actual sampling rate mostly stable or does it vary over time?
10 years, 8 months ago (2010-04-15 11:03:47 UTC) #2
mnaganov (inactive)
10 years, 8 months ago (2010-04-15 11:36:46 UTC) #3
On 2010/04/15 11:03:47, Søren Gjesse wrote:
> LGTM
> 
> Is the actual sampling rate mostly stable or does it vary over time?

So far, I observed stable behavior (on Linux and Mac).

Powered by Google App Engine
This is Rietveld 408576698