Issue 1539034: Add inline caches for loading non-existing properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1539034: Add inline caches for loading non-existing properties. (Closed)

Created:
10 years, 8 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add inline caches for loading non-existing properties. Committed: http://code.google.com/p/v8/source/detail?r=4401

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -3 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View	3 chunks	+12 lines, -0 lines	2 comments	Download
M	src/stub-cache.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

I think nonexistent is a better word than non-existing. Since it's one word the E ...

10 years, 8 months ago (2010-04-13 19:18:36 UTC) #2

Mads Ager (chromium)

10 years, 8 months ago (2010-04-14 06:26:10 UTC) #3

Changed to nonexistent. Thanks!

http://codereview.chromium.org/1539034/diff/1/2
File src/stub-cache.h (right):

http://codereview.chromium.org/1539034/diff/1/2#newcode487
src/stub-cache.h:487: 
On 2010/04/13 19:18:37, Erik Corry wrote:
> Extra blank line?

Good catch, removed.

Expand Messages | Collapse Messages