Issue 1539033: Fix build problems on Windows 64-bit by casting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1539033: Fix build problems on Windows 64-bit by casting. (Closed)

Created:
10 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Fix build problems on Windows 64-bit by casting. Gave the root register a name for reference.

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -26 lines)			Patch
M	src/circular-queue.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/circular-queue-inl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	6 chunks	+7 lines, -6 lines	2 comments	Download
M	src/x64/builtins-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
	src/x64/macro-assembler-x64.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/register-allocator-x64-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM, even though I would like to not have all the static_cast<int>'s. http://codereview.chromium.org/1539033/diff/1/7 File src/runtime.cc ...

10 years, 8 months ago (2010-04-13 11:35:37 UTC) #2

Lasse Reichstein

10 years, 8 months ago (2010-04-13 11:52:44 UTC) #3

I don't want them either, but that's a much bigger change. This just makes them
explicit instead of implicit.

http://codereview.chromium.org/1539033/diff/1/7
File src/runtime.cc (right):

http://codereview.chromium.org/1539033/diff/1/7#newcode6385
src/runtime.cc:6385: int save_date = date;  // Need this for ASSErRT in the end.
Fixed.

Expand Messages | Collapse Messages