Issue 1539023: Bookmark manager: Fix tree indentation...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1539023: Bookmark manager: Fix tree indentation... (Closed)

Created:
10 years, 8 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
feldstein

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bookmark manager: Fix tree indentation BUG=39228 TEST=Create lots of nested folders (more than 10 levels deep). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43683

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -30 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/css/tree.css.js	View		1 chunk	+0 lines, -26 lines	0 comments	Download
	M	chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js	View		8 chunks	+53 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

feldstein

10 years, 8 months ago (2010-04-06 00:56:57 UTC) #2

LGTM after missing semicolon

http://codereview.chromium.org/1539023/diff/1/3
File chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js (right):

http://codereview.chromium.org/1539023/diff/1/3#newcode99
chrome/browser/resources/bookmark_manager/js/cr/ui/tree.js:99: return 0
semicolon

Expand Messages | Collapse Messages