Geolocation exceptions window, Windows....

Geolocation exceptions window, Windows.

This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable.

BUG=39817
TEST=Geolocation exceptions window exists on windows, allows sorting by either column

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43669

[Peter Kasting, 2010-04-05 20:15:32]

mattm: Model and GTK changes.
thakis: Mac changes.
sky: Windows changes.

[Nico, 2010-04-05 20:20:21]

Mac changes LG.

http://codereview.chromium.org/1539021/diff/1/10
File chrome/browser/cocoa/geolocation_exceptions_window_controller.mm (right):

http://codereview.chromium.org/1539021/diff/1/10#newcode191
chrome/browser/cocoa/geolocation_exceptions_window_controller.mm:191:
[removeButton_ setEnabled:(model_->CanRemoveExceptions(rows)];
Nit: Drop surrounding parens

[sky, 2010-04-05 20:41:47]

http://codereview.chromium.org/1539021/diff/12001/3009
File chrome/browser/geolocation/geolocation_content_settings_table_model.cc
(right):

http://codereview.chromium.org/1539021/diff/12001/3009#newcode95
chrome/browser/geolocation/geolocation_content_settings_table_model.cc:95:
entries_.erase(entries_.begin() + row);
Would be nice to null out entry here as erase will delete it.

http://codereview.chromium.org/1539021/diff/12001/3009#newcode200
chrome/browser/geolocation/geolocation_content_settings_table_model.cc:200:
while (entries_[row1].origin != entries_[row1].embedding_origin)
Is it possible for row1/row2 to go negative here?

[Peter Kasting, 2010-04-05 20:47:01]

You didn't need to review the model changes, sky...

http://codereview.chromium.org/1539021/diff/12001/3009
File chrome/browser/geolocation/geolocation_content_settings_table_model.cc
(right):

http://codereview.chromium.org/1539021/diff/12001/3009#newcode95
chrome/browser/geolocation/geolocation_content_settings_table_model.cc:95:
entries_.erase(entries_.begin() + row);
On 2010/04/05 20:41:47, sky wrote:
> Would be nice to null out entry here as erase will delete it.

I reset |entry| a few lines down, so it doesn't seem worth it, but I did add an
EOL comment about this.

http://codereview.chromium.org/1539021/diff/12001/3009#newcode200
chrome/browser/geolocation/geolocation_content_settings_table_model.cc:200:
while (entries_[row1].origin != entries_[row1].embedding_origin)
On 2010/04/05 20:41:47, sky wrote:
> Is it possible for row1/row2 to go negative here?

That would mean there are child exceptions with no parent.  That can't happen
during normal operation.  It could happen if the user manually hacks their
Preferences file, but we already have many places we don't sanity-check the
Preferences file enough to avoid crashing.

[sky, 2010-04-05 20:56:11]

LGTM

[mattm, 2010-04-05 20:58:56]

lgtm