Issue 1539018: Mac: Make image dragging 162.4% more awesome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1539018: Mac: Make image dragging 162.4% more awesome. (Closed)

Created:
10 years, 8 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), viettrungluu

CC:
chromium-reviews

Visibility:
Public.

Mac: Make image dragging 162.4% more awesome. Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently. BUG=11457, 18992 TEST=(all require the webkit patch, so this won't work yet) http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html Dragging should show image http://www.google.com/ Dragging google image should show image http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg Dragging image should work, drag image should be smaller than image itself Random website Mark some text, drag it. Should show drag cursor and no image Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43631

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -17 lines)			Patch
M	chrome/browser/cocoa/web_drag_source.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/web_drag_source.mm	View	1 2	5 chunks	+17 lines, -11 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View		4 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	skia/ext/skia_utils_mac.mm	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

The skbitmap->cgimage conversion isn't as bad as it looks, because the renderer side scales the ...

10 years, 8 months ago (2010-04-04 04:03:55 UTC) #1

L 162.4% GTM