Issue 1535016: We should also delete the underlying persistent public key...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1535016: We should also delete the underlying persistent public key... (Closed)

Created:
10 years, 8 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Jens Alfke

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr., rsleevi-old

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

We should delete the underlying persistent public key only when we cannot sign the challenge. This matches what Mozilla does. Fix nits. R=snej BUG=148 TEST=No compilation errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43524

Patch Set 1 #

Patch Set 2 : Make albertb's suggested changes. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	net/base/keygen_handler_nss.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	net/base/keygen_handler_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/base/keygen_handler_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages