VMWare/VirtualBox: Fix (broke earlier today w/ GPT switchover)

VMWare/VirtualBox: Fix (broke earlier today w/ GPT switchover)

[Bill Richardson, 2010-03-31 17:29:49]

Just a couple of minor things.

http://codereview.chromium.org/1535008/diff/1/2
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/1535008/diff/1/2#newcode81
src/scripts/image_to_vmware.sh:81: grep "$ROOTFS_GUID" | awk '{print $1}') * 512
))  # bytes
Use this instead:

OFFSET=$(partoffset "${FLAGS_from}/chromiumos_image.bin" 3)

ROOTFS A is always in partition 3. If for some reason we decide to install image
B as well, you'd get two matches for ROOTFS_GUID.

http://codereview.chromium.org/1535008/diff/1/2#newcode85
src/scripts/image_to_vmware.sh:85: sudo losetup -o $OFFSET "$LOOP_DEV"
"$TEMP_IMG"
Need some cleanup handlers in case of errors after this point.

http://codereview.chromium.org/1535008/diff/1/2#newcode87
src/scripts/image_to_vmware.sh:87: sudo mount "$LOOP_DEV" "$TEMP_MNT"
Here too.

[adlr, 2010-04-01 00:07:35]

please take another look.

thanks,

http://codereview.chromium.org/1535008/diff/1/2
File src/scripts/image_to_vmware.sh (right):

http://codereview.chromium.org/1535008/diff/1/2#newcode81
src/scripts/image_to_vmware.sh:81: grep "$ROOTFS_GUID" | awk '{print $1}') * 512
))  # bytes
On 2010/03/31 17:29:49, Bill Richardson wrote:
> Use this instead:
> 
> OFFSET=$(partoffset "${FLAGS_from}/chromiumos_image.bin" 3)
> 
> ROOTFS A is always in partition 3. If for some reason we decide to install
image
> B as well, you'd get two matches for ROOTFS_GUID.
> 
> 

Done.

http://codereview.chromium.org/1535008/diff/1/2#newcode85
src/scripts/image_to_vmware.sh:85: sudo losetup -o $OFFSET "$LOOP_DEV"
"$TEMP_IMG"
On 2010/03/31 17:29:49, Bill Richardson wrote:
> Need some cleanup handlers in case of errors after this point.

Done.

http://codereview.chromium.org/1535008/diff/1/2#newcode87
src/scripts/image_to_vmware.sh:87: sudo mount "$LOOP_DEV" "$TEMP_MNT"
On 2010/03/31 17:29:49, Bill Richardson wrote:
> Here too.

Done.

[Bill Richardson, 2010-04-01 00:15:14]

LGTM