Issue 1530040: Down to only 4 dirs that don't pass the license checker.

Issue 1530040: Down to only 4 dirs that don't pass the license checker. (Closed)

Created:
10 years, 8 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

Pass tools/licenses.py for more directories. We're now down to only 4 dirs that don't pass the license checker. They will require separate changes. Modify the license checker to only print failing dirs. BUG=39240 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44656

Patch Set 1 #

Patch Set 2 : missing files #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -16 lines)			Patch
M	third_party/cld/README.chromium	View	1 chunk	+5 lines, -4 lines	1 comment	Download
A	third_party/modp_b64/LICENSE	View	1 chunk	+33 lines, -0 lines	1 comment	Download
M	third_party/modp_b64/README.chromium	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	third_party/tcmalloc/LICENSE	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	third_party/tcmalloc/README.chromium	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	tools/licenses.py	View	3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with small snits http://codereview.chromium.org/1530040/diff/2001/3001 File third_party/cld/README.chromium (right): http://codereview.chromium.org/1530040/diff/2001/3001#newcode6 third_party/cld/README.chromium:6: This library is opened-source Google ...

10 years, 8 months ago (2010-04-14 22:36:49 UTC) #2

Evan Martin

10 years, 8 months ago (2010-04-15 15:29:31 UTC) #3

On 2010/04/14 22:36:49, Marc-Antoine Ruel wrote:
> lgtm with small snits
> 
> http://codereview.chromium.org/1530040/diff/2001/3001
> File third_party/cld/README.chromium (right):
> 
> http://codereview.chromium.org/1530040/diff/2001/3001#newcode6
> third_party/cld/README.chromium:6: This library is opened-source Google code. 
> It is as of now directly
> open-sourced? I haz no English skillz.
> 
> http://codereview.chromium.org/1530040/diff/2001/3002
> File third_party/modp_b64/LICENSE (right):
> 
> http://codereview.chromium.org/1530040/diff/2001/3002#newcode5
> third_party/modp_b64/LICENSE:5: * Copyright &copy; 2005, 2006  Nick Galbreath
--
> nickg [at] modp [dot] com
> use (c) instead.

That is literal text from the source code, but I think you're right.

Expand Messages | Collapse Messages