Issue 1530009: Make image verification test script call big_{firmware|kernel} tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1530009: Make image verification test script call big_{firmware|kernel} tests. (Closed)

Created:
10 years, 8 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

Make image verification test script call big_{firmware|kernel} tests.

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/platform/vboot_reference/tests/run_image_verification_tests.sh	View		4 chunks	+12 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 8 months ago (2010-03-30 22:40:06 UTC) #2

LGTM

http://codereview.chromium.org/1530009/diff/1/2
File src/platform/vboot_reference/tests/run_image_verification_tests.sh (right):

http://codereview.chromium.org/1530009/diff/1/2#newcode33
src/platform/vboot_reference/tests/run_image_verification_tests.sh:33: cd
${TEST_DIR} && ${TEST_DIR}/big_firmware_tests
Another way to write this might be:

cd ${TEST_DIR} && ${TEST_DIR}/big_firmware_tests || return_code=255

Yours is probably more readable though :-)

Expand Messages | Collapse Messages