Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: chrome/browser/extensions/extension_history_api.cc

Issue 1530002: Move history API out of experimental. Allow extensions to override history page. (Closed)
Patch Set: Rebase for commit. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_history_api.cc
diff --git a/chrome/browser/extensions/extension_history_api.cc b/chrome/browser/extensions/extension_history_api.cc
index 7edbf14d25142c3e85ca665b169444a9ee19046b..1614a801d00b5e4902326329e88fd0691fcbdaef 100644
--- a/chrome/browser/extensions/extension_history_api.cc
+++ b/chrome/browser/extensions/extension_history_api.cc
@@ -49,8 +49,10 @@ void GetVisitInfoDictionary(const history::VisitRow& row,
value->SetReal(keys::kVisitTime, MilliSecondsFromTime(row.visit_time));
value->SetString(keys::kReferringVisitId,
Int64ToString(row.referring_visit));
- value->SetInteger(keys::kTransition,
- row.transition && PageTransition::CORE_MASK);
+
+ const char* trans = PageTransition::CoreTransitionString(row.transition);
+ DCHECK(trans) << "Invalid transition.";
+ value->SetString(keys::kTransition, trans);
}
void AddVisitNode(const history::VisitRow& row, ListValue* list) {
« no previous file with comments | « chrome/browser/extensions/extension_history_api.h ('k') | chrome/browser/extensions/extension_history_api_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698