bring machine_install() up to date with memento_updater flags.

bring machine_install() up to date with memento_updater flags.

[seano, 2010-04-16 20:56:25]

PTAL

[truty, 2010-04-16 21:34:12]

I can't figure out if the empty version_string path is required for this
iteration.  I think your comment implies that you're going to do the lookup for
LATEST version# that fills the else clause in your next iteration.  True?

http://codereview.chromium.org/1528044/diff/1/2
File server/hosts/chromiumos_host.py (right):

http://codereview.chromium.org/1528044/diff/1/2#newcode37
server/hosts/chromiumos_host.py:37: version_string = ''
Don't you want this to be None?

http://codereview.chromium.org/1528044/diff/1/2#newcode71
server/hosts/chromiumos_host.py:71: raise ChromiumOSError('OS Updater failed on
%s', self.hostname)
Why not include the whole update_url for debugging?

[seano, 2010-04-16 21:47:56]

PTAL

http://codereview.chromium.org/1528044/diff/1/2
File server/hosts/chromiumos_host.py (right):

http://codereview.chromium.org/1528044/diff/1/2#newcode37
server/hosts/chromiumos_host.py:37: version_string = ''
On 2010/04/16 21:34:13, truty wrote:
> Don't you want this to be None?

Done.

http://codereview.chromium.org/1528044/diff/1/2#newcode71
server/hosts/chromiumos_host.py:71: raise ChromiumOSError('OS Updater failed on
%s', self.hostname)
On 2010/04/16 21:34:13, truty wrote:
> Why not include the whole update_url for debugging?

This is the hostname of the client box we're logging.

But yeah, I'll print the URL too.

[truty, 2010-04-16 21:50:01]

LGTM