Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: chrome/common/extensions/extension_unpacker.cc

Issue 1528018: Make an error message verbose to investigate a un-reproducible bug.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_unpacker.cc
===================================================================
--- chrome/common/extensions/extension_unpacker.cc (revision 43601)
+++ chrome/common/extensions/extension_unpacker.cc (working copy)
@@ -41,7 +41,7 @@
// Errors
const char* kCouldNotCreateDirectoryError =
- "Could not create directory for unzipping.";
+ "Could not create directory for unzipping: ";
const char* kCouldNotDecodeImageError = "Could not decode theme image.";
const char* kCouldNotUnzipExtension = "Could not unzip extension.";
const char* kPathNamesMustBeAbsoluteOrLocalError =
@@ -150,7 +150,12 @@
temp_install_dir_ =
extension_path_.DirName().AppendASCII(kTempExtensionName);
if (!file_util::CreateDirectory(temp_install_dir_)) {
- SetError(kCouldNotCreateDirectoryError);
+#if defined(OS_WIN)
+ std::string dir_string = WideToUTF8(temp_install_dir_.value());
+#else
+ std::string dir_string = temp_install_dir_.value();
+#endif
+ SetError(kCouldNotCreateDirectoryError + dir_string);
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698