Fix bug in string replace regexp with function when returning non-string.

Fix bug in string replace regexp with function when returning non-string.

[Lasse Reichstein, 2010-03-29 16:07:32]

Small review.

[fschneider, 2010-03-29 16:21:47]

LGTM.

http://codereview.chromium.org/1528005/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/1528005/diff/1/2#newcode453
src/string.js:453: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
Long line.

http://codereview.chromium.org/1528005/diff/1/2#newcode467
src/string.js:467: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
Long line.

[Vitaly Repeshko, 2010-03-29 16:52:53]

Drive by comment.


Thanks,
Vitaly

http://codereview.chromium.org/1528005/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/1528005/diff/1/2#newcode453
src/string.js:453: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
You can use func_result = TO_STRING_INLINE(func_result). Note: TO_STRING_INLINE
takes a variable.

http://codereview.chromium.org/1528005/diff/1/2#newcode467
src/string.js:467: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
Same here.

[Lasse Reichstein, 2010-03-29 18:58:31]

http://codereview.chromium.org/1528005/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/1528005/diff/1/2#newcode453
src/string.js:453: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
Line wrapped.
Re. TO_STRING_INLINE, I considered it, but it seems wasteful to do the identity
assignment if the result is a string.

http://codereview.chromium.org/1528005/diff/1/2#newcode467
src/string.js:467: if (!IS_STRING(func_result)) func_result =
NonStringToString(func_result);
Dittos.