Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1527007: Support setting brekpoint by script name set in //@ scriptURL= comment, (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support setting brekpoint by script name set in //@ scriptURL= comment, in case script name is missing. BUG=http://crbug.com/39290 Author: Andrey Kosyakov (caseq@chromium.org) Original issue: http://codereview.chromium.org/1303003 TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M src/debug-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +24 lines, -0 lines 0 comments Download
M src/mirror-debugger.js View 2 chunks +1 line, -25 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 4 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 8 months ago (2010-04-01 16:24:23 UTC) #1
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-06 09:34:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698