Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1525040: Do not preconvert to string as it apparently has minimal performance benefit. (Closed)

Created:
10 years, 8 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Do not preconvert to string as it apparently has minimal performance benefit. Committed: http://code.google.com/p/v8/source/detail?r=4448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/array.js View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Lasse, may you have a look?
10 years, 8 months ago (2010-04-19 12:40:29 UTC) #1
Lasse Reichstein
10 years, 8 months ago (2010-04-20 09:01:24 UTC) #2
LGTM.
Sniff. I liked that "optimization".

Powered by Google App Engine
This is Rietveld 408576698