Issue 1524009: Use gflags in teartest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1524009: Use gflags in teartest. (Closed)

Created:
10 years, 8 months ago by Alexey Marinichev

Modified:
9 years, 7 months ago

Reviewers:
piman

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Visibility:
Public.

Patch Set 2 : nit #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -36 lines)			Patch
M	client/deps/glbench/src/Makefile	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	client/deps/glbench/src/main.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	client/deps/glbench/src/teartest.cc	View	1	6 chunks	+13 lines, -32 lines	0 comments	Download
M	client/deps/glbench/src/xlib_window.cc	View		3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM with 1 nit http://codereview.chromium.org/1524009/diff/1/4 File client/deps/glbench/src/teartest.cc (right): http://codereview.chromium.org/1524009/diff/1/4#newcode22 client/deps/glbench/src/teartest.cc:22: DEFINE_int32(refresh, 0, "If 1 or ...

10 years, 8 months ago (2010-04-02 01:33:22 UTC) #2

Alexey Marinichev

10 years, 8 months ago (2010-04-02 02:24:09 UTC) #3

http://codereview.chromium.org/1524009/diff/1/4
File client/deps/glbench/src/teartest.cc (right):

http://codereview.chromium.org/1524009/diff/1/4#newcode22
client/deps/glbench/src/teartest.cc:22: DEFINE_int32(refresh, 0, "If 1 or more,
target refresh rate; otherwise enable vsync");
On 2010/04/02 01:33:22, piman wrote:
> 80 cols

Done.

Expand Messages | Collapse Messages

Issue 1524009: Use gflags in teartest. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Messages