Add final remainging strings for geolocation, for the exceptions dialog....

Add final remainging strings for geolocation, for the exceptions dialog.

BUG=39817
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43358

[joth, 2010-04-01 16:05:29]

Peter,
Here's my stab at adding the final strings. If there's major issues, feel free
to use this as a patch to build your own change on or I can submit this and then
you make tweaks as a follow up.
Joth

[Peter Kasting, 2010-04-01 16:46:30]

LGTM, thanks!  I don't know whether in the end we'll want to capitalize
"embedded", but we can probably figure that out once things are on-screen.

http://codereview.chromium.org/1524006/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/1524006/diff/1/2#newcode4346
chrome/app/generated_resources.grd:4346: <message
name="IDS_EXCEPTIONS_NOT_SET_BUTTON" desc="A place-holder button in exception
dialogs for setting an exception rule for a given domain that has not yet been
set.">
Nit: The comments on all these that say "button" currently lie, since they're
all just text labels... perhaps change these all to say something like "A label
to display in the "action" column when a site's content setting is
allowed/ask/blocked/not set"?

[joth, 2010-04-01 16:57:08]

The lower case embedded struck me too. From
http://mocks/glen/chrome/spec/89_geo2/4/#04_exceptions.png I think it meshes
pretty well with the lower-case domain names on the parent rows.
But yes, agree it will be best judged when assembled in the final dialogs.

Cheers,

http://codereview.chromium.org/1524006/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/1524006/diff/1/2#newcode4346
chrome/app/generated_resources.grd:4346: <message
name="IDS_EXCEPTIONS_NOT_SET_BUTTON" desc="A place-holder button in exception
dialogs for setting an exception rule for a given domain that has not yet been
set.">
On 2010/04/01 16:46:30, Peter Kasting wrote:
> Nit: The comments on all these that say "button" currently lie, since they're
> all just text labels... perhaps change these all to say something like "A
label
> to display in the "action" column when a site's content setting is
> allowed/ask/blocked/not set"?

yep, I thought so too, but wasn't sure whether this was a forward-looking
comment to some future form of the UI.
Done.