Allow extension overinstall

chrome/browser/extensions/extension_management_browsertest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/ref_counted.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/extensions/autoupdate_interceptor.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/extensions/extension_updater.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/ui_test_utils.h"
 
 class ExtensionManagementTest : public ExtensionBrowserTest {
  protected:
   // Helper method that returns whether the extension is at the given version.
   // This calls version(), which must be defined in the extension's bg page,
   // as well as asking the extension itself.
+  //
+  // Note that 'version' here means something different than the version field
+  // in the extension's manifest. We use the version as reported by the
+  // background page to test how overinstalling crx files with the same
+  // manifest version works.
   bool IsExtensionAtVersion(Extension* extension,
                             const std::string& expected_version) {
     // Test that the extension's version from the manifest and reported by the
     // background page is correct.  This is to ensure that the processes are in
     // sync with the Extension.
     ExtensionProcessManager* manager = browser()->profile()->
         GetExtensionProcessManager();
     ExtensionHost* ext_host = manager->GetBackgroundHostForExtension(extension);
     EXPECT_TRUE(ext_host);
     if (!ext_host)
@@ skipping 32 matching lines @@
         service->extensions()->at(size_before)->id(),
         test_data_dir_.AppendASCII("permissions-high-v2.crx"), -1))
       return false;
     EXPECT_EQ(size_before, service->extensions()->size());
     if (service->disabled_extensions()->size() != 1u)
       return false;
     return true;
   }
 };
 
-// Tests that installing the same version does not overwrite.
+// Tests that installing the same version overwrites.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, InstallSameVersion) {
   ExtensionsService* service = browser()->profile()->GetExtensionsService();
   const size_t size_before = service->extensions()->size();
   ASSERT_TRUE(InstallExtension(
       test_data_dir_.AppendASCII("install/install.crx"), 1));
+  FilePath old_path = service->extensions()->back()->path();
 
-  // Install an extension with the same version. The previous install should
-  // be kept.
+  // Install an extension with the same version. The previous install should be
+  // overwritten.
   ASSERT_TRUE(InstallExtension(
       test_data_dir_.AppendASCII("install/install_same_version.crx"), 0));
+  FilePath new_path = service->extensions()->back()->path();
 
-  EXPECT_TRUE(IsExtensionAtVersion(service->extensions()->at(size_before),
-                                   "1.0"));
+  EXPECT_FALSE(IsExtensionAtVersion(service->extensions()->at(size_before),
+                                    "1.0"));
+  EXPECT_NE(old_path.value(), new_path.value());
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, InstallOlderVersion) {
   ExtensionsService* service = browser()->profile()->GetExtensionsService();
   const size_t size_before = service->extensions()->size();
   ASSERT_TRUE(InstallExtension(
       test_data_dir_.AppendASCII("install/install.crx"), 1));
   ASSERT_TRUE(InstallExtension(
       test_data_dir_.AppendASCII("install/install_older_version.crx"), 0));
   EXPECT_TRUE(IsExtensionAtVersion(service->extensions()->at(size_before),
@@ skipping 136 matching lines @@
   service->updater()->CheckNow();
   ASSERT_TRUE(WaitForExtensionInstallError());
 
   // Make sure the extension state is the same as before.
   extensions = service->extensions();
   ASSERT_EQ(size_before + 1, extensions->size());
   ASSERT_EQ("ogjcoiohnmldgjemafoockdghcjciccf",
             extensions->at(size_before)->id());
   ASSERT_EQ("2.0", extensions->at(size_before)->VersionString());
 }