Allow extension overinstall

chrome/browser/extensions/extension_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_browsertest.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 79 matching lines @@
   virtual void ConfirmInstall(Delegate* delegate, Extension* extension) {
     delegate->InstallUIAbort();
     MessageLoopForUI::current()->Quit();
   }
 
   virtual void ConfirmUninstall(Delegate* delegate, Extension* extension) {}
 
   virtual void OnInstallSuccess(Extension* extension) {}
 
   virtual void OnInstallFailure(const std::string& error) {}
-
-  virtual void OnOverinstallAttempted(Extension* extension) {}
 };
 
 bool ExtensionBrowserTest::InstallOrUpdateExtension(const std::string& id,
                                                     const FilePath& path,
                                                     InstallUIType ui_type,
                                                     int expected_change) {
   ExtensionsService* service = browser()->profile()->GetExtensionsService();
   service->set_show_extensions_prompts(false);
   size_t num_before = service->extensions()->size();
 
   {
     NotificationRegistrar registrar;
     registrar.Add(this, NotificationType::EXTENSION_LOADED,
                   NotificationService::AllSources());
     registrar.Add(this, NotificationType::EXTENSION_UPDATE_DISABLED,
                   NotificationService::AllSources());
-    registrar.Add(this, NotificationType::EXTENSION_OVERINSTALL_ERROR,
-                  NotificationService::AllSources());
     registrar.Add(this, NotificationType::EXTENSION_INSTALL_ERROR,
                   NotificationService::AllSources());
 
     ExtensionInstallUI* install_ui = NULL;
     if (ui_type == INSTALL_UI_TYPE_CANCEL)
       install_ui = new MockAbortExtensionInstallUI();
     else if (ui_type == INSTALL_UI_TYPE_NORMAL)
       install_ui = new ExtensionInstallUI(browser()->profile());
 
     scoped_refptr<CrxInstaller> installer(
@@ skipping 164 matching lines @@
       std::cout << "Got EXTENSION_INSTALLED notification.\n";
       ++extension_installs_observed_;
       MessageLoopForUI::current()->Quit();
       break;
 
     case NotificationType::EXTENSION_INSTALL_ERROR:
       std::cout << "Got EXTENSION_INSTALL_ERROR notification.\n";
       MessageLoopForUI::current()->Quit();
       break;
 
-    case NotificationType::EXTENSION_OVERINSTALL_ERROR:
-      std::cout << "Got EXTENSION_OVERINSTALL_ERROR notification.\n";
-      MessageLoopForUI::current()->Quit();
-      break;
-
     case NotificationType::EXTENSION_PROCESS_CREATED:
       std::cout << "Got EXTENSION_PROCESS_CREATED notification.\n";
       MessageLoopForUI::current()->Quit();
       break;
 
     case NotificationType::EXTENSION_PROCESS_TERMINATED:
       std::cout << "Got EXTENSION_PROCESS_TERMINATED notification.\n";
       MessageLoopForUI::current()->Quit();
       break;
 
@@ skipping 23 matching lines @@
         MessageLoopForUI::current()->Quit();
       }
       break;
     }
 
     default:
       NOTREACHED();
       break;
   }
 }