Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1521010: Eliminate WebCore include paths when compiling Chromium code.... (Closed)

Created:
10 years, 8 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews, jam+cc_chromium.org, dpranke+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Eliminate WebCore include paths when compiling Chromium code. In the process of trying to do this, I discovered some unnecessary config.h includes as well as some remaining WebCore function calls. R=dglazkov BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43574

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -100 lines) Patch
M DEPS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/extensions/v8/benchmarking_extension.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M webkit/extensions/v8/gc_extension.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/extensions/v8/gears_extension.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/extensions/v8/interval_extension.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/extensions/v8/playback_extension.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/extensions/v8/profiler_extension.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_platform_delegate_mac.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp View 1 2 1 chunk +3 lines, -29 lines 0 comments Download
M webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp View 1 2 1 chunk +3 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
10 years, 8 months ago (2010-04-01 04:52:20 UTC) #1
dglazkov
10 years, 8 months ago (2010-04-01 14:27:32 UTC) #2 
This looks great! Thank you for this clean-up! It looks though like
WebSystemInterface.h is no longer on any search path (see Mac build fail).

Powered by Google App Engine
This is Rietveld 408576698