Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1520031: build: Suppress stupid question in image_to_usb.sh. (Closed)

Created:
10 years, 8 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

build: Suppress stupid question in image_to_usb.sh. No point in asking the user if they're sure they want to modify the image for testing when they asked us to modify it for testing in the first place. BUG=none TEST=tried it

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scripts/image_to_usb.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years, 8 months ago (2010-04-10 01:26:04 UTC) #1
Chris Masone
10 years, 8 months ago (2010-04-10 01:35:33 UTC) #2
LGTM

On Fri, Apr 9, 2010 at 6:26 PM, <derat@chromium.org> wrote:

> Reviewers: cmasone,
>
> Description:
> build: Suppress stupid question in image_to_usb.sh.
>
> No point in asking the user if they're sure they want
> to modify the image for testing when the asked us to
> modify it for testing in the first place.
>
> BUG=none
> TEST=tried it
>
> Please review this at http://codereview.chromium.org/1520031/show
>
> Affected files:
>  M src/scripts/image_to_usb.sh
>
>
> Index: src/scripts/image_to_usb.sh
> diff --git a/src/scripts/image_to_usb.sh b/src/scripts/image_to_usb.sh
> index
>
ad033ccbc4d6f06c228507228dbaea478bd7ee2e..b89725acfe41718b2985e8e0ffd63f31eab04770
> 100755
> --- a/src/scripts/image_to_usb.sh
> +++ b/src/scripts/image_to_usb.sh
> @@ -96,7 +96,7 @@ if [ ${FLAGS_test_image} -eq ${FLAGS_TRUE} ] ; then
>     cp -f "${SRC_IMAGE}" "${FLAGS_from}/chromiumos_test_image.bin"
>     # Modify it.
>     "${SCRIPTS_DIR}/mod_image_for_test.sh" --image \
> -      "${FLAGS_from}/chromiumos_test_image.bin"
> +      "${FLAGS_from}/chromiumos_test_image.bin" --yes
>   fi
>   # Use it.
>   SRC_IMAGE="${FLAGS_from}/chromiumos_test_image.bin"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698