Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: webkit/glue/webview_impl.cc

Issue 152003: Fix some issues with extension messaging: (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/renderer_extension_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc
index e40d27bd6f574827d7c5691bb37caa58ddbe6cec..926512973699056c8efef3c4f3b44dff384ae511 100644
--- a/webkit/glue/webview_impl.cc
+++ b/webkit/glue/webview_impl.cc
@@ -907,10 +907,6 @@ bool WebViewImpl::ShouldClose() {
}
void WebViewImpl::Close() {
- // Do this first to prevent reentrant notifications from being sent to the
- // initiator of the close.
- delegate_ = NULL;
-
if (page_.get()) {
// Initiate shutdown for the entire frameset. This will cause a lot of
// notifications to be sent.
@@ -923,6 +919,10 @@ void WebViewImpl::Close() {
if (devtools_agent_.get())
devtools_agent_.reset(NULL);
+ // Do this first to prevent reentrant notifications from being sent to the
+ // initiator of the close.
+ delegate_ = NULL;
+
Release(); // Balances AddRef from WebView::Create
}
« no previous file with comments | « chrome/renderer/resources/renderer_extension_bindings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698