Issue 152003: Fix some issues with extension messaging:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 152003: Fix some issues with extension messaging: (Closed)

Created:
11 years, 5 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix some issues with extension messaging: - Disconnect ports properly (javascript mistake). - Use the right port ID when dispatching the disconnect event. - Fix a bug with 2 extensions loaded in the same process. BUG=12686 BUG=15798 TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19844

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -36 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_message_service.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_message_service.cc	View	5 chunks	+18 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_messages_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/resources/event_bindings.js	View	2 chunks	+14 lines, -3 lines	0 comments	Download
M	chrome/renderer/resources/extension_process_bindings.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View	1 chunk	+16 lines, -8 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages