Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1520025: Fix presubmit_unittests on some versions of python2.5.... (Closed)

Created:
10 years, 8 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix presubmit_unittests on some versions of python2.5. On our hardy boxes, the python has the json module, but it doesn't have all the expected methods. Fallback to simplejson if it doesn't have json.loads(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43907

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M presubmit_support.py View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
tony
10 years, 8 months ago (2010-04-08 01:29:33 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/1520025/diff/1/2 File presubmit_support.py (right): http://codereview.chromium.org/1520025/diff/1/2#newcode44 presubmit_support.py:44: json.loads That doesn't throw on 2.6? In any ...
10 years, 8 months ago (2010-04-08 01:31:58 UTC) #2
tony
10 years, 8 months ago (2010-04-08 01:38:00 UTC) #3
On 2010/04/08 01:31:58, Marc-Antoine Ruel wrote:
> lgtm
> 
> http://codereview.chromium.org/1520025/diff/1/2
> File presubmit_support.py (right):
> 
> http://codereview.chromium.org/1520025/diff/1/2#newcode44
> presubmit_support.py:44: json.loads
> That doesn't throw on 2.6?
> 
> In any case, even if it would, at worst it'll fallback to the embedded version
> so it's no big deal.

Tried python2.5 and 2.6 on my mac.  Works fine (uses the system json) when using
python2.6.

Powered by Google App Engine
This is Rietveld 408576698