Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1520001: Start using String type info: (Closed)

Created:
10 years, 9 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Start using String type info: * Improved string concatenation. * Fixed type inference in prefix/postfix count operations. Committed: http://code.google.com/p/v8/source/detail?r=4305

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -57 lines) Patch
M src/ia32/codegen-ia32.cc View 1 14 chunks +63 lines, -27 lines 0 comments Download
M src/type-info.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 11 chunks +74 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vitaly Repeshko
10 years, 9 months ago (2010-03-27 19:34:11 UTC) #1
fschneider
LGTM with comments addressed. http://codereview.chromium.org/1520001/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1520001/diff/1/2#newcode1198 src/ia32/codegen-ia32.cc:1198: } else if (operands_type.IsString()) { ...
10 years, 9 months ago (2010-03-29 08:42:20 UTC) #2
Vitaly Repeshko
All comments addressed. Please take another look. Thanks, Vitaly http://codereview.chromium.org/1520001/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1520001/diff/1/2#newcode1198 src/ia32/codegen-ia32.cc:1198: ...
10 years, 9 months ago (2010-03-29 10:29:31 UTC) #3
fschneider
LGTM.
10 years, 9 months ago (2010-03-29 11:05:18 UTC) #4
Vitaly Repeshko
10 years, 9 months ago (2010-03-29 11:52:23 UTC) #5
Thanks for quick review! Submitted.


-- Vitaly

Powered by Google App Engine
This is Rietveld 408576698