Issue 1519032: Fix bug that was revealed by arm cross-compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1519032: Fix bug that was revealed by arm cross-compilation. (Closed)

Created:
10 years, 8 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Fix bug that was revealed by arm cross-compilation.

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tpmd/unix/tpmd.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

10 years, 8 months ago (2010-04-12 21:39:47 UTC) #2

LGTM

semenzato@chromium.org (semenzato@chromium.org) wrote:
> Reviewers: msb,
>
> Message:
> Thanks!
>
>
> Description:
> Fix bug that was revealed by arm cross-compilation.
>
> Please review this at http://codereview.chromium.org/1519032/show
>
> Affected files:
>   M tpmd/unix/tpmd.c
>
>
> Index: tpmd/unix/tpmd.c
> diff --git a/tpmd/unix/tpmd.c b/tpmd/unix/tpmd.c
> index  
>
061ef48057d7d77ea09637564056369e71cc31ba..0194a236d91e28a2f6ff722d11461d089c7bd68a

> 100644
> --- a/tpmd/unix/tpmd.c
> +++ b/tpmd/unix/tpmd.c
> @@ -171,7 +171,7 @@ static void print_usage(char *name)
>
>  static void parse_options(int argc, char **argv)
>  {
> -    char c;
> +    int c;
>      struct passwd *pwd;
>      struct group *grp;
>      opt_uid = getuid();
>
>

Expand Messages | Collapse Messages