Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: src/log.h

Issue 1519027: Make VM state tracking to be independent of logging and profiling. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 846ab67ded081c2ba4e565c7c919b3d5a5612383..fb934038b251cf437f27b20a790b3d212027ef35 100644
--- a/src/log.h
+++ b/src/log.h
@@ -87,30 +87,6 @@ class CompressionHelper;
#define LOG(Call) ((void) 0)
#endif
-class VMState BASE_EMBEDDED {
-#ifdef ENABLE_LOGGING_AND_PROFILING
- public:
- inline VMState(StateTag state);
- inline ~VMState();
-
- StateTag state() { return state_; }
- Address external_callback() { return external_callback_; }
- void set_external_callback(Address external_callback) {
- external_callback_ = external_callback;
- }
-
- private:
- bool disabled_;
- StateTag state_;
- VMState* previous_;
- Address external_callback_;
-#else
- public:
- explicit VMState(StateTag state) {}
-#endif
-};
-
-
#define LOG_EVENTS_AND_TAGS_LIST(V) \
V(CODE_CREATION_EVENT, "code-creation", "cc") \
V(CODE_MOVE_EVENT, "code-move", "cm") \
@@ -264,10 +240,6 @@ class Logger {
static void LogRuntime(Vector<const char> format, JSArray* args);
#ifdef ENABLE_LOGGING_AND_PROFILING
- static StateTag state() {
- return current_state_ ? current_state_->state() : OTHER;
- }
-
static bool is_logging() {
return logging_nesting_ > 0;
}
@@ -354,12 +326,6 @@ class Logger {
// of samples.
static Profiler* profiler_;
- // A stack of VM states.
- static VMState* current_state_;
-
- // Singleton bottom or default vm state.
- static VMState bottom_state_;
-
// SlidingStateWindow instance keeping a sliding window of the most
// recent VM states.
static SlidingStateWindow* sliding_state_window_;
« no previous file with comments | « src/api.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698