Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/log.cc

Issue 1519027: Make VM state tracking to be independent of logging and profiling. (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.h ('k') | src/log-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 2d16044e9d7156bde50ec25fa98a76d7acb4ecd8..8aefe989573fa325d7178afbf1a2aa69ab0ba7b4 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -162,8 +162,7 @@ void StackTracer::Trace(TickSample* sample) {
}
int i = 0;
- const Address callback = Logger::current_state_ != NULL ?
- Logger::current_state_->external_callback() : NULL;
+ const Address callback = VMState::external_callback();
if (callback != NULL) {
sample->stack[i++] = callback;
}
@@ -327,8 +326,6 @@ void Profiler::Run() {
//
Ticker* Logger::ticker_ = NULL;
Profiler* Logger::profiler_ = NULL;
-VMState* Logger::current_state_ = NULL;
-VMState Logger::bottom_state_(EXTERNAL);
SlidingStateWindow* Logger::sliding_state_window_ = NULL;
const char** Logger::log_events_ = NULL;
CompressionHelper* Logger::compression_helper_ = NULL;
@@ -1481,7 +1478,7 @@ bool Logger::Setup() {
}
}
- current_state_ = &bottom_state_;
+ ASSERT(VMState::current_state_ == NULL); // NULL implies outermost external.
ticker_ = new Ticker(kSamplingIntervalMs);
« no previous file with comments | « src/log.h ('k') | src/log-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698