Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1518037: Cancel IPv6 probe jobs during shutdown.... (Closed)

Created:
10 years, 8 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Cancel IPv6 probe jobs during shutdown. This works around bug where chrome sometimes leaks URLRequests past destruction of the IO thread. BUG=41986 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45003

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a DCHECK for shutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/base/host_resolver_impl.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
10 years, 8 months ago (2010-04-19 18:38:06 UTC) #1
jar (doing other things)
LGTM... but I had a small suggestion to go further below. http://codereview.chromium.org/1518037/diff/1/2 File net/base/host_resolver_impl.cc (right): ...
10 years, 8 months ago (2010-04-19 18:49:05 UTC) #2
eroman
Done. I added a DCHECK that new probe jobs aren't added post Shutdown, and a ...
10 years, 8 months ago (2010-04-19 21:21:13 UTC) #3
jar (doing other things)
10 years, 8 months ago (2010-04-19 21:28:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698